-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add server_jolokia_metrics_whitelist
parameter
#826
Conversation
Should I also accept a special value that turns on unauthenticated access, instead of populating the ie Variant[Enum['NOAUTH'],Array[String[1]]] Or maybe also accept Variant[Boolean, Array[String[1]]] Or maybe a whitelist is overly complicated and I should have gone for a simple boolean! |
rebased. @ekohl Does this look ok? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm OK with this. I haven't used the metrics myself so I'll trust you on the specifics. The defaults don't change anything so 👍
Do we want to drop the comment describing the default?
manifests/init.pp
Outdated
@@ -537,6 +537,10 @@ | |||
# invokes when on static_file_content requests. | |||
# Defaults to undef | |||
# | |||
# $server_jolokia_metrics_whitelist:: The whitelist of clients that | |||
# can query the jolokia /metrics/v2 endpoint | |||
# Defaults to [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO there's no need to document the default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed and rebased.
When set, allows listed clients access to the V2 (jolokia) metrics endpoint. See https://puppet.com/docs/puppet/7/server/metrics-api/v2/metrics_api.html
When set, allows listed clients access to the V2 (jolokia) metrics
endpoint.
See https://puppet.com/docs/puppet/7/server/metrics-api/v2/metrics_api.html